Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConcurrentModificationException in LocalActivityMeteringHelper #2108

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix ConcurrentModificationException in LocalActivityMeteringHelper #2108

merged 1 commit into from
Jun 13, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Jun 12, 2024 •
edited
Loading

Fix ConcurrentModificationException in LocalActivityMeteringHelper. newWFTStarting was calling remove on firstWftActivities in a for loop iterating over firstWftActivities which is not allowed.

closes #2107

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner June 12, 2024 21:27
Sushisource
Sushisource approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that works fine. Thanks for fixing!

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit ddda99b into temporalio:master Jun 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent Modification Exception when executing workflow with local activities
2 participants
@Quinn-With-Two-Ns @Sushisource