Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix signal CAN non determinism test #2084

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix signal CAN non determinism test #2084

merged 2 commits into from
May 31, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Fix race in testSignalContinueAsNewNonDeterminism where the workflow may have not processed a signal before we started attempting to introduce non determinism.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner May 29, 2024 21:28
@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Fix signal can non determinism Fix signal CAN non determinism test May 29, 2024
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit cde114c into temporalio:master May 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz