Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply serialization context to Dynamic Workflows #1992

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Apply serialization context to Dynamic Workflows #1992

merged 1 commit into from
Feb 16, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

What was changed

Apply serialization context to Dynamic Workflows

Why?

Serialization context should be applied inside a workflow even if it is dynamic

Checklist

  1. Closes Verify DynamicWorkflows implementation applies serialization  #1982

  2. How was this tested:
    Added new integration test to cover dynamic workflow and activity

  3. Any docs updates needed?
    No

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 16, 2024 19:20
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit f4a572a into temporalio:master Feb 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@chronos-tachyon chronos-tachyon Awaiting requested review from chronos-tachyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify DynamicWorkflows implementation applies serialization
2 participants
@Quinn-With-Two-Ns @cretz