Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doclink tool's duplicate docstring generation issue #1773

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

yuandrew
Copy link
Contributor

@yuandrew yuandrew commented Jan 13, 2025

What was changed

  • Removed duplicate "Exposed as" comments
  • added ability to detect/delete stale aliases
  • handle edge case where gofmt reorders the doc comment (i.e. UpsertSearchAttributes from workflow.go)

Why?

Unintended behavior

Checklist

  1. Closes Doclink bug: duplicate "Exposed as" strings being generated #1774

  2. How was this tested:

Manually added and removed aliases

  1. Any docs updates needed?

…te stale aliases. Handle edge case where gofmt reorders the doc comment
@yuandrew yuandrew requested a review from a team as a code owner January 13, 2025 21:54
@yuandrew yuandrew merged commit 3506cd2 into temporalio:master Jan 14, 2025
13 checks passed
@yuandrew yuandrew deleted the fix-godoc-updater-duplicate branch January 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doclink bug: duplicate "Exposed as" strings being generated
2 participants