Fix CI after GHA's drop of node16 actions #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Nov 28, 2024
|
@cretz Leaving that to you. Just merge if you are ok with it. |
|
Moving this to draft while I test it... |
cretz
force-pushed
the
fix-gha-node16-deprecation
branch
from
c5c569e to
e5d754f
Compare
|
Confirmed working after minor YAML change, thanks @mjameswh! Updating branch then merging after CI complete... |
cretz
changed the title
cretz
force-pushed
the
fix-gha-node16-deprecation
branch
from
e5d754f to
69cc609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Modified our GHA workflows so that when building the release-grade native artifacts on Linux targets, only the actual Rust compilation step runs inside a GLIBC 2.24-based Docker container; all other operations are performed directly on the runner, which can now be any recent Ubuntu.
This was required because GHA no longer allows actions based on Node16 (i.e. actions are forced to use Node20 instead), but Node20 requires at least GLIBC 2.28. It is therefore not possible to have a single execution environment that can both execute Node20-based actions, yet produces native libraries that can then execute in the GLIBC 2.24-based environments that some of our users have.
Fixes [Bug] CI build is broken due to GHA dropping support for node16-based actions #373.