Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn or error when update handlers dangle across CAN or workflow exit #261

Closed
drewhoskins-temporal opened this issue Jun 4, 2024 · 1 comment · Fixed by #294
Closed

Comments

@drewhoskins-temporal
Copy link

drewhoskins-temporal commented Jun 4, 2024

We can recommend the await-all-handlers or drop-all-handlers methods. TBD whether error or warning.

@dandavison
Copy link
Contributor

I've merged the first PR, for Python: temporalio/sdk-python#556

The basic spec that that PR's proposing for other SDKs is

  • Workflow code can wait on a method named similarly to workflow.all_handlers_finished()

  • By default, the worker will emit workflow.UnfinishedUpdateHandlersWarning and workflow.UnfinishedSignalHandlersWarning if any handlers of those types are unfinished when the workflow completes (cancellation, failure, success). See PR for wording of message.

  • These warnings are controlled by a policy whose default value is workflow.HandlerUnfinishedPolicy.WARN_AND_ABANDON

  • Users can silence the warning on a per-handler basis by setting unfinished_policy to workflow.HandlerUnfinishedPolicy.ABANDON

  • Tests should verify the above for worker-side workflow exit via cancellation, failure, and success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants