Update Java SDK #705
Merged
Update Java SDK #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
commented
Dec 6, 2024
| updateResult = | ||
| WorkflowClient.executeUpdateWithStart( | ||
| workflow::returnInitResult, | ||
| UpdateOptions.<TxResult>newBuilder().build(), |
There was a problem hiding this comment.
Much cleaner implementation!
| @@ -34,4 +36,10 @@ public WorkflowInboundCallsInterceptor interceptWorkflow(WorkflowInboundCallsInt | |||
| public ActivityInboundCallsInterceptor interceptActivity(ActivityInboundCallsInterceptor next) { | |||
| return new SimpleCountActivityInboundCallsInterceptor(next); | |||
| } | |||
|
|
|||
| @Override | |||
| public NexusOperationInboundCallsInterceptor interceptNexusOperation( | |||
There was a problem hiding this comment.
The "correct" solution is these samples should be SimpleCountWorkerInterceptor extends BaseWorkerInterceptor
stephanos
commented
Dec 7, 2024
|
|
||
| public class SimpleCountWorkerInterceptor implements WorkerInterceptor { | ||
| public class SimpleCountWorkerInterceptor extends WorkerInterceptorBase { |
There was a problem hiding this comment.
To provide a base implementation for Nexus.
stephanos
requested review from
tsurdilo,
antmendoza and
a team
as code owners
stephanos
commented
Dec 9, 2024
| @@ -105,9 +105,8 @@ public void testUpdateIdempotency() { | |||
| .newWorkflowStub( | |||
| ClusterManagerWorkflow.class, | |||
| WorkflowOptions.newBuilder().setTaskQueue(testWorkflowRule.getTaskQueue()).build()); | |||
| CompletableFuture<ClusterManagerWorkflow.ClusterManagerResult> result = | |||
There was a problem hiding this comment.
I got an error for an unused variable 🤷
steveandroulakis
approved these changes
Dec 9, 2024
| updateResult = | ||
| WorkflowClient.executeUpdateWithStart( | ||
| workflow::returnInitResult, | ||
| UpdateOptions.<TxResult>newBuilder().build(), |
There was a problem hiding this comment.
Much cleaner implementation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated Java SDK to pull in new Update-with-Start API.