Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SafeMessageHandlers/ClusterManagerWorkflowTests - periodically failing last assertion #81

Closed
rross opened this issue Aug 19, 2024 · 0 comments · Fixed by #85
Closed
Labels
bug Something isn't working

Comments

@rross
Copy link
Contributor

rross commented Aug 19, 2024

What are you really trying to do?

Run all the tests for the .NET Samples without having any tests failing

Describe the bug

The SafeMessageHandlers/ClusterManagerWorkflowTests test is periodically failing even when no changes are made to either the test or the code being tested. I've seen this on my laptop as well as in build-lint-test running in Github. Example Integration.

TemporalioSamples.Tests.SafeMessageHandlers.ClusterManagerWorkflowTests.StartWorkflowAsync_SimpleJobSet_Succeeds(testContinueAsNew: True) [1 s]
  Error Message:
   Assert.Equal() Failure
Expected: True
Actual:   False
  Stack Trace:
     at TemporalioSamples.Tests.SafeMessageHandlers.ClusterManagerWorkflowTests.<>c__DisplayClass1_0.<<StartWorkflowAsync_SimpleJobSet_Succeeds>b__0>d.MoveNext() in /_/tests/SafeMessageHandlers/ClusterManagerWorkflowTests.cs:line 62
--- End of stack trace from previous location ---
   at Temporalio.Worker.TemporalWorker.ExecuteInternalAsync(Func`1 untilComplete, CancellationToken stoppingToken)
   at Temporalio.Worker.TemporalWorker.ExecuteInternalAsync(Func`1 untilComplete, CancellationToken stoppingToken)
   at TemporalioSamples.Tests.SafeMessageHandlers.ClusterManagerWorkflowTests.StartWorkflowAsync_SimpleJobSet_Succeeds(Boolean testContinueAsNew) in /_/tests/SafeMessageHandlers/ClusterManagerWorkflowTests.cs:line 27

Minimal Reproduction

dotnet clean
dotnet build
dotnet test

May have to run this several times to see it break.

Environment/Versions

  • OS and processor: M2 Max Mac, and Ubuntu
  • Temporal Version: CLI: 1.0.0 (Server 1.24.2, UI 2.28.0).
  • Are you using Docker or Kubernetes or building Temporal from source? No
@rross rross added the bug Something isn't working label Aug 19, 2024
cretz added a commit to cretz/temporal-samples-dotnet that referenced this issue Aug 29, 2024
@cretz cretz closed this as completed in #85 Aug 30, 2024
cretz added a commit that referenced this issue Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant