EDU-2392: Removing repetitive code snippet #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brianmacdonald-temporal Ready for review |
|
I don't see any problems but be aware that with at least one of these patches, there was a subtle but important difference between the two code snippets that seemed to be redundant at first and, in fact, needed clarification as to what each one did. I'm cc'ing in @axfelix for a second pair of eyes |
|
This one is actually redundant, though it's a bit unintuitive now, it should really segue directly into this part https://docs.temporal.io/develop/python/versioning#deprecated-patches to show an example of |
|
Thanks for checking @axfelix Going to approve and unblock. |
fairlydurable
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notes to reviewers