Include additional build-time information in the version string #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly caused this in CI
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
? github.com/temporalio/cli/cmd/temporal [no test files]
? github.com/temporalio/cli/temporalcli/commandsmd [no test files]
? github.com/temporalio/cli/temporalcli/internal/cmd/gen-commands [no test files]
? github.com/temporalio/cli/temporalcli/internal/printer/test [no test files]
2024/08/19 13:15:51 INFO No logger configured for temporal client. Created default one.
2024/08/19 13:15:52 INFO No logger configured for temporal client. Created default one.
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x20 pc=0xd3a40a]
This reverts commit a3c507a.
cretz
approved these changes
Aug 19, 2024
|
Thanks @cretz. Yeah, so we basically have to be happy with it being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #635
Support injection of build-time information into the version string printed by the binary on startup and via
--version. See code comments and docs for further explanation.