Skip to content

Commit

Permalink
Remove disabling UTF-8 validation hack (#205)
Browse files Browse the repository at this point in the history
**What changed?**
Remove the hack to allow disabling UTF-8 validation on our Go protos.

**Why?**
We should allow protobuf to validate all strings are valid UTF-8 as specified.

**How did you test it?**
Will be tested by server, sdk, and other components.

**Potential risks**
Anyone still using invalid UTF-8 will see their grpc requests fail. We've been monitoring for this in Temporal Cloud for most of a year now and there's no more invalid data. Self-hosted users should do the same validation before upgrading to a server or Go SDK release that contains this change (instructions [here](https://github.com/temporalio/temporal/releases/tag/v1.24.0)).
  • Loading branch information
dnr authored Jan 24, 2025
1 parent 0e5a507 commit a53ea3f
Show file tree
Hide file tree
Showing 39 changed files with 9,752 additions and 10,199 deletions.
98 changes: 49 additions & 49 deletions activity/v1/message.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a53ea3f

Please sign in to comment.