Add cache_method directive: cache the specified request methods only. (#494) #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,6 +159,33 @@ static TfwStr g_crlf = { .ptr = S_CRLF, .len = SLEN(S_CRLF) }; | |||
| } \ | |||
| for ( ; c != h_end; ++c, c = (c == u_end) ? h_start : c) | |||
|
|
|||
| static unsigned int tfw_cache_method_noncacheable = (1 << TFW_HTTP_METH_POST); | |||
There was a problem hiding this comment.
Why TFW_HTTP_METH_POST? The issue requires "GET only must be cached by default" and this is differnt, probably its better to use tfw_cache_meth = (1 << TFW_HTTP_METH_GET) and reverse the logic.
Please don't use so long names, tfw_cache_meth_nc would be enough for the variable and the functions at the below.
|
Good to merge after several cleanups |
keshonok
force-pushed
the
ab-cfg-cache-method
branch
from
0657cea
to
b7845d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.