Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listeners reconfig #1613

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Listeners reconfig #1613

merged 3 commits into from
Apr 29, 2022

Conversation

avbelov23
Copy link
Contributor

krizhanovsky
krizhanovsky requested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most crucial issue is that we might get a crash in runtime on adding more than 8 listening sockets. But there are also several places for improvement.

fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
@krizhanovsky krizhanovsky mentioned this pull request Apr 18, 2022
Closed
krizhanovsky
krizhanovsky reviewed Apr 26, 2022
View reviewed changes
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/http_limits.c Outdated Show resolved Hide resolved
fw/http_limits.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
krizhanovsky
krizhanovsky requested changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still several issues to fix as well as some minor cleanups and coding style adjustments

fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Show resolved Hide resolved
fw/sock_clnt.c Show resolved Hide resolved
@avbelov23 avbelov23 force-pushed the avb-1105 branch 2 times, most recently from 6e81e8f to 627ed61 Compare April 27, 2022 19:10
krizhanovsky
krizhanovsky reviewed Apr 27, 2022
View reviewed changes
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Outdated Show resolved Hide resolved
krizhanovsky
krizhanovsky reviewed Apr 28, 2022
View reviewed changes
fw/sock_clnt.c Outdated Show resolved Hide resolved
fw/sock_clnt.c Show resolved Hide resolved
krizhanovsky
krizhanovsky requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main question is about zero tfw_listen_socks_sz, but maybe I missed something. We can discuss this on the call.

@avbelov23 avbelov23 force-pushed the avb-1105 branch 2 times, most recently from 46e81eb to 58e8496 Compare April 28, 2022 14:48
krizhanovsky
krizhanovsky approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge!

@avbelov23 avbelov23 merged commit 096127f into master Apr 29, 2022
@avbelov23 avbelov23 deleted the avb-1105 branch April 29, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizhanovsky krizhanovsky krizhanovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avbelov23 @krizhanovsky