Fix #1170 #1173
Merged
Fix #1170 #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup on initialization phase.
Split crypto_alloc_tfm() into crypto_find_*() sleepable part and atomic, suitable for calling from softirq, crypto_alloc_*_atomic(). Previously crypto_find_alg() called moules loading and used semaphore synchronization, so we had softlockups in TLS handshakes. Tempesta TLS: 1. Call crypto_find_*() for all configured algorithms on start phase, so in run-time we have the ready algs and can quickly allocate crypt contexts; 2. Determine maximum size of crypt request also on start phase and use it for per-cpu requests allocation instead of wrong 8-byte constant. 3. Remove some dead code (crypto.h definitions mostly).
Print warnings on TTLS_ERR_BAD_INPUT_DATA in ttls_encrypt(): we have net reatelimited warnings, so this won't cause serious logging problems.
arithmetics in tcp_write_xmit() (double TLS header size accounting). Account TCP FIN flag in comparing TCP seqnos with skb->len.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are in kernel tempesta-tech/linux-4.14.32-tfw#6 :
Also merge md.[ch] with cipher.[ch]