Use all space in allocated skbs #1189
Comments
vankoven
added a commit
that referenced
this issue
Mar 11, 2019
…aged fragments ss_skb_frag_next() is always work with TfwMsgIter, so renamed and moved into msg.h, the whole TfwMsgIter became invalid if the function fails.
vankoven
added a commit
that referenced
this issue
Mar 13, 2019
* Don't create linear skb part for huge messages, it's easier to walk over them using TfwMsgIter * ss_skb_frag_next() is always work with TfwMsgIter, so renamed and moved into msg.h. * tfw_http_msg_add_data() and tfw_msg_write() are very similar functions, unify them
vankoven
added a commit
that referenced
this issue
Mar 26, 2019
fix #1189: correctly fill header part of skb when writing data into p…
avbelov23
pushed a commit
that referenced
this issue
Jul 2, 2019
…aged fragments ss_skb_frag_next() is always work with TfwMsgIter, so renamed and moved into msg.h, the whole TfwMsgIter became invalid if the function fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Noticed by @aleksostapenko in #1162 (comment)
It seems that there is a problem with using skb header when allocating more than one skb - in
tfw_http_msg_setup()each skb is allocated with a place under the header:tempesta/tempesta_fw/ss_skb.h
Line 174 in 5631d72
but in
tfw_msg_write()only the header of the first skb in list is used (it->frag < 0):tempesta/tempesta_fw/msg.c
Line 59 in 5631d72
for subsequent skb
it-> fragis always initialized to zero:tempesta/tempesta_fw/ss_skb.h
Line 132 in 5631d72
so then we always fall into the
it->frag >= 0branch.Looks like the current master version of
tfw_msg_write()has the same issue.The text was updated successfully, but these errors were encountered: