Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pop() and set_vt() to use clock_timestamp() instead of now() #383

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Change pop() and set_vt() to use clock_timestamp() instead of now() #383

merged 1 commit into from
Feb 22, 2025

Conversation

brianpursley
Copy link
Contributor

Fixes #367

@brianpursley
Copy link
Contributor Author

Let me know if you want tests for this

@jumski
Copy link
Contributor

jumski commented Feb 21, 2025

Looks good @brianpursley, thanks for fixing it!

ChuckHend
ChuckHend approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@ChuckHend ChuckHend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@v0idpwn v0idpwn merged commit 7fd411d into tembo-io:main Feb 22, 2025
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v0idpwn v0idpwn v0idpwn approved these changes

@ChuckHend ChuckHend ChuckHend approved these changes

@theory theory Awaiting requested review from theory theory is a code owner

@vrmiguel vrmiguel Awaiting requested review from vrmiguel vrmiguel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistently use clock_timestamp() instead of now() when working with vt
4 participants
@brianpursley @jumski @v0idpwn @ChuckHend