Update sqlx to 0.7.2 #131
Merged
Update sqlx to 0.7.2 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
requested review from
ChuckHend,
nhudson,
sjmiller609 and
vrmiguel
as code owners
v0idpwn
force-pushed
the
chore/bump-sqlx
branch
from
fa0d6a7 to
4907825
Compare
|
@pbzweihander I rebased your PR and did some chore since 0.7.2 was released. Do you think its good to go? |
vrmiguel
reviewed
Oct 2, 2023
pgmq-rs/Cargo.toml
Outdated
| thiserror = "1.0.38" | ||
| tokio = { version = "1", features = ["macros"] } | ||
| tokio = { version = "1", features = ["macros", "rt-multi-thread"] } |
There was a problem hiding this comment.
Without this feature in tokio, I get the following error: https://github.com/tembo-io/pgmq/actions/runs/6389164710/job/17340134252?pr=131
Is there a better solution?
There was a problem hiding this comment.
Couldn't compile the test.
---- src/lib.rs - PGMQueue::set_vt (line 873) stdout ----
error: The default runtime flavor is `multi_thread`, but the `rt-multi-thread` feature is disabled.
--> src/lib.rs:884:1
|
13 | #[tokio::main]
| ^^^^^^^^^^^^^^
|
= note: this error originates in the attribute macro `tokio::main` (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to previous error
|
I think it is good to go! |
ChuckHend
approved these changes
Oct 3, 2023
Closed
vrmiguel
approved these changes
Oct 4, 2023
vrmiguel
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.