Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#824 | New user friendly component for tuple inputs #872

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 12, 2024

Fixes #824

Description

Until now, the only way to input tuple parameters was through the TupleStructInput component, which is a simple input, and the user has to deal with the complexity of the specific format for each case. Now, using TupleStruct the user can navigate through the complexity of the value structure and fill each property input with a simple value.

Tests Scenarios

Go to the Write section of this contract to test some tuple functions
https://deploy-preview-872--dev-mainnet-teloscan.netlify.app/address/0xc5F13247b1a2547Fd0f6C7696695cDFeB003027c?tab=contract&subtab=write

image

image

@Viterbo Viterbo self-assigned this Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit f2fcb1d
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/673e31416220830008e8e0bd
😎 Deploy Preview https://deploy-preview-872--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit f2fcb1d
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/673e31413fd4df0008985456
😎 Deploy Preview https://deploy-preview-872--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit f2fcb1d
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/673e31417f4e950008d981f8
😎 Deploy Preview https://deploy-preview-872--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmjanus
Copy link
Contributor

pmjanus commented Nov 18, 2024

  1. Si hay varios niveles el primero abierto
  2. Alinear el espacio entre elementos

pmjanus
pmjanus previously approved these changes Nov 19, 2024
src/components/inputs/TupleStruct.vue Outdated Show resolved Hide resolved
src/components/ContractTab/FunctionInterface.vue Outdated Show resolved Hide resolved
@pmjanus
Copy link
Contributor

pmjanus commented Nov 20, 2024

A small detail here is that in the example you link all of these parameters are part of the tuple but the last one seems to be indented a little bit more than the others. https://deploy-preview-872--dev-mainnet-teloscan.netlify.app/address/0xc5F13247b1a2547Fd0f6C7696695cDFeB003027c?tab=contract&subtab=write

@pmjanus pmjanus self-requested a review November 21, 2024 13:13
@pmjanus pmjanus merged commit 11a7f4e into dev Nov 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants