#789 | Fetch internal transactions from new API #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viterbo
changed the title
…89-adapt-the-way-we-query-the-last-internal-transactions-for-an-address
|
There is an issue with this one:
|
pmjanus
approved these changes
Nov 20, 2024
pmjanus
deleted the
789-adapt-the-way-we-query-the-last-internal-transactions-for-an-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #789
Only if this link(solved in this PR) shows version >= 1.2.3
Blocked by https://github.com/telosnetwork/teloscan-indexer/pull/281
Description
This PR adapts the component showing the last internal transaction for a given address or in general. The count column was removed along with the expand/collapse column because now we can paginate directly from the internal transaction API instead of having to fetch transactions first in order to then fetch the corresponding internal transactions for each previous result.
However, given the fact that the API is not completely ready, a result sample was hardcoded and the fetching of the data is currently simulated (with 2 seconds of simulated loading) to show the new component in action while we wait for the indexer API to be completed.
Test scenarios