Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#602 | Initial allowances page #632

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Oct 6, 2023

Fixes #602

Description

This PR adds the page and control elements for allowances

Test scenarios

  • git fetch --all && git checkout 602-allowances-layout && yarn dev
  • go to http://localhost:8081
  • log in
    • you should see a new allowances menu item
  • go to allowances page
    • it should match the designs (some text has been changed)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@ezra-sg ezra-sg self-assigned this Oct 6, 2023
@ezra-sg ezra-sg marked this pull request as ready for review October 6, 2023 23:06
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming good 👍
Approved!

bun.lockb Outdated Show resolved Hide resolved
@pmjanus pmjanus linked an issue Oct 16, 2023 that may be closed by this pull request
@donnyquixotic donnyquixotic merged commit 4062857 into epic-allowances Oct 16, 2023
1 check passed
@donnyquixotic donnyquixotic deleted the 602-allowances-layout branch October 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowances - Page Layout
3 participants