-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update pls feed to support puslechain mainnet & testnet #683
Conversation
Hi @johnny-vu, thanks for making these prs, really cool to see. I'm curious why do you need to wait for multicall deployment, shouldn't it already be available by default in pulsechain since its already available in ethereum mainnet. |
Hi @akremstudy, thanks for your feedback. My apologies, I think the repo should be multicall.py In my opinion, we can define What do you think? |
Yeah thats the repo you're looking for, the banteg/multicall repo, thats where you want to make a pr to add the pulsechain network. add_multicall_support(
network="Pulsechain",
network_id=369,
state_override=False,
multicall3_address="0xcA11bde05977b3631167028862bE2a173976CA11",
) |
@akremstudy thank you. I'm clear for now. I've submitted new PR is here and we'll see how it all goes. |
Awesome! |
Hi @akremstudy I've done this PR, could you please take a look? Quick question, should I wait for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @johnny-vu!
Thanks @akremstudy! |
This changes will support to get
PLS/USD
spot price on pulsechain mainnet (chainId: 369) & testnet (chainId: 943)Summary
pls_usd_feed
, usingPriceAggregator
with multiple sources.tests/feeds/test_pls_usd_feed.py
Steps Taken to QA Changes
https://scan.pulsechain.com/tx/0xee26f75be1672bbbcee33e657cd56ba017f05033634a0526fd1a75c3825a76da
Checklist
This pull request is:
<link to issue>
" in this Pull Request's summary section.<link to issue>
" in this Pull Request's summary section.Happy engineering!