Implements go-to-first-input #133
Conversation
isundaylee
force-pushed
the
go-to-first-input
branch
from
85a86b0 to
9ef7df3
Compare
|
Just tested my rebased version on the newer upstream. Seems to work as expected. Would there be any interests in merging this? This seems to be a requested feature. Thanks! |
|
@danielcompton are there any blockers to merging this? Anecdotally speaking, this is one of the most commonly used features among vimium users (on both chrome and firefox). |
|
Looks good to me 👍. I think this should be merged. |
Vimari Extension/js/settings.js
Outdated
| @@ -17,6 +17,7 @@ function getSettings() { | |||
| 'scrollDownHalfPage': 'd', | |||
| 'goToPageTop': 'g g', | |||
| 'goToPageBottom': 'shift+g', | |||
| 'goToFirstInput': 'g i', | |||
There was a problem hiding this comment.
This line is causing a conflict as js/settings.js is replaced by json/defaultSettings.json. If you would be able to add this line there instead I would like to merge this.
isundaylee
force-pushed
the
go-to-first-input
branch
from
9ef7df3 to
bf8f6b5
Compare
isundaylee
force-pushed
the
go-to-first-input
branch
from
bf8f6b5 to
8c4d66b
Compare
|
@nbelzer Just rebased on master and pushed the change. I couldn't test it after the rebase though - so it'd be great if you can help build and test it. Thank you for looking at this! |
|
@isundaylee Thanks, it works. Will be merging this. |
Implements the functionality of focusing the first input on the page (preferring the first input in the current view area if one exists). Inspiration and general algorithm are from sVim.
For example, on a Google results page, pressing
g iwill focus the search box so that the user can type in a new query.Default key binding set to
g i.