Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListEditor.setValue does not work as expected #3

Closed
wesvetter opened this issue Oct 2, 2018 · 0 comments
Closed

ListEditor.setValue does not work as expected #3

wesvetter opened this issue Oct 2, 2018 · 0 comments
Assignees
@wesvetter
Labels
bug

Comments

@wesvetter
Copy link
Member

There are two (related) issues with the ListEditor:

  1. setValue doesn't work – calling setValue(['foo']) then getValue() does not return ['foo'].
  2. The calling render() does not re-render the list after the initial call, and it modifies the result of getValue().

This is a bug in the original implementation. See here, here, and here. There is an unmerged solution.
@wesvetter wesvetter added the bug label Oct 2, 2018
@wesvetter wesvetter self-assigned this Oct 2, 2018
wesvetter added a commit that referenced this issue Oct 3, 2018
@wesvetter
Fix setValue, render in ListEditor
3c43b1d 
Closes #3
@wesvetter wesvetter mentioned this issue Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesvetter wesvetter

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wesvetter