Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated attributes #442

Merged
merged 9 commits into from
Aug 7, 2024
Merged

remove deprecated attributes #442

merged 9 commits into from
Aug 7, 2024

Conversation

Yannie258
Copy link

@Yannie258 Yannie258 commented Aug 6, 2024 •
edited
Loading

Description

remove @Fails-Annotation deprecated attributes

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

yeng added 8 commits August 5, 2024 15:12
remove validFor out of @failed
0a92ead
remove assertPageIsShown/assertPageIsNotShown out of AbstractPage
b8b92c2
Merge remote-tracking branch 'upstream/master' into bug/remove-deprec…
73c5c6a 
…ated-attributes
replace deprecated validFor and ticketId attributes in @fails Annotation
a4b3e69
Merge remote-tracking branch 'origin/bug/remove-deprecated-attributes…
8aff8f9 
…' into bug/remove-deprecated-fails-attributes

# Conflicts:
#	integration-tests/src/test/java/eu/tsystems/mms/tic/testframework/playground/ReportingAllStatesTests.java
Merge remote-tracking branch 'origin/bug/remove-deprecated-attributes…
077e27f 
…' into bug/remove-deprecated-fails-attributes
Merge remote-tracking branch 'origin/bug/remove-deprecated-attributes…
bec6298 
…' into bug/remove-deprecated-fails-attributes
remove related validFor and ticketId attributes
3636507
@Yannie258 Yannie258 force-pushed the refactor/remove-deprecated-attributes branch from 69d9718 to 40c00d9 Compare August 7, 2024 11:52
@Yannie258 Yannie258 force-pushed the refactor/remove-deprecated-attributes branch from 40c00d9 to c875f22 Compare August 7, 2024 13:05
@martingrossmann martingrossmann merged commit 65a8fce into telekom:master Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martingrossmann martingrossmann martingrossmann approved these changes

@mreiche mreiche Awaiting requested review from mreiche mreiche is a code owner

@mbeuthan mbeuthan Awaiting requested review from mbeuthan mbeuthan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yannie258 @martingrossmann