Feature/documentation update #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasAdler
requested review from
mreiche,
martingrossmann,
gogro,
mbeuthan and
wolamms
as code owners
| ---- | ||
|
|
||
| TIP: All defined properties can be overwritten later by adding system parameters to your command. + | ||
| (e.a `-D{browser_setting}=firefox`) | ||
|
|
||
| All supported browsers are listed in <<WebdriverManager properties>> | ||
|
|
||
| The tests will be started using the browser that is installed on the local machine if you do not provide a version in the properties. | ||
| If you want to use a specific browser version that is not installed, Selenium Manager will automatically download the required version of Firefox or Chrome in the background if you add your desired version to the properties. |
There was a problem hiding this comment.
The additional note if you add your desired version to the properties can be removed, it's doublicate.
| == Setup Selenium | ||
| == Setup Selenium (optional) | ||
|
|
||
| You do not have to set up a web driver manually, as the Selenium Manager automatically handles the download of the drivers. |
There was a problem hiding this comment.
The first sentence seems to be doublicate. Selenium Manager is already mentioned some lines above.
| @@ -35,7 +35,8 @@ The following prerequisites must be met | |||
|
|
|||
| . Concrete execution environment: Layout tests should run in a concrete browser environment to ensure the comparability of the screenshots. | |||
There was a problem hiding this comment.
Please, can you fix the list of prerequisites? The first point is marked with ., all other with **. But imho all points have the same priority and level.
All points should only have - as list sign.
| === Manually configure WebDriver binaries | ||
|
|
||
| - Search for your browser's Selenium driver online, like _selenium gecko driver_ for Firefox or _selenium crome driver_ for Chrome based browsers | ||
| - Search for your browser's Selenium driver online, like _selenium gecko driver_ for Firefox or _selenium chrome driver_ for Chrome based browsers |
There was a problem hiding this comment.
I think this information is not needed for Testerra users.
martingrossmann
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some sections of the documentation are outdated, for example due to the new Selenium Manager feature.
configfailurepolicyType of change
Please delete options that are not relevant.
Checklist: