Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixing/report ng log view #433

Merged
merged 9 commits into from
Jul 16, 2024
Merged

Bugfixing/report ng log view #433

merged 9 commits into from
Jul 16, 2024

Conversation

Yannie258
Copy link

@Yannie258 Yannie258 commented Jun 12, 2024 •
edited
Loading

Description

  • refactor the virtual-log-view component to make code cleaner and easier to maintain
  • fix the view-log screen fit to page-screen
  • fix the highlight mark when searching special characters by removing unnecessary html Escape in log-line

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann
Copy link
Contributor

Like discussed the performance of log view search is very bad. Please, can you recheck your changes? If there is no other way please deactivate timestamp search.

martingrossmann
martingrossmann reviewed Jul 8, 2024
View reviewed changes
report-ng/app/src/components/log-view/abstract-log-view.ts
@@ -37,11 +40,27 @@ export abstract class AbstractLogView {
@bindable({defaultBindingMode: bindingMode.toView})
searchRegexp:RegExp;

//improve performance
//The cache uses the timestamp as the key and the formatted timestamp as the value.
private timestampCache: Map<number, string> = new Map<number, string>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... the cache seems to be help to improve the performance to a acceptable level.

remove checking hardcode timestampPattern for searchRegex to keep the…
6c7528b 
… checkMatches work when Timestamp format will be changed
@martingrossmann martingrossmann merged commit 2401ecd into telekom:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martingrossmann martingrossmann martingrossmann approved these changes

@mreiche mreiche Awaiting requested review from mreiche mreiche is a code owner

@gogro gogro Awaiting requested review from gogro

@mbeuthan mbeuthan Awaiting requested review from mbeuthan mbeuthan is a code owner

@wolamms wolamms Awaiting requested review from wolamms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yannie258 @martingrossmann