Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added class filter for threads view #425

Merged

Conversation

selinanatschke-mms
Copy link
Collaborator

@selinanatschke-mms selinanatschke-mms commented May 14, 2024

Description

  • added class filter for threads view
  • filters can not be active at the same time => to prevent this and show user that he cannot use them at the same time, filters will be disabled
    • note: to achieve this, we need extra variables _selectedClass and _selectedStatus; otherwise after refreshing the page while we have an active filter, the other both filter fields will not be disabled anymore
    • note: when we have one of the select filters active (class or status) the selection was removed out of the select box although the filter remained active. This caused that you were neither able to deactivate the filter nor activate another filter since they were disabled
      => to solve this i added "ref" to the mdc-selects which modify statusSelect and classSelect
      => these will put the selected filter option actively in the select field again when the filter is reactivated after a page refresh
      (feel free to ask me if anything is unclear here, also see https://aurelia-ui-toolkits.github.io/aurelia-mdc-web/#/select/examples first example - 'Select Banana' Button)
  • summarized zoomInOnMethods(), zoomInOnMethodsWithStatus() to one function _zoomInOnFilter() to be able to reuse it for method, status and class filter
  • added class information to the tooltip

note for screenshots: the zoom still works, i just cut off the lower part of the threads view in these screenshots
image

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@selinanatschke-mms selinanatschke-mms marked this pull request as ready for review June 10, 2024 07:18
@martingrossmann martingrossmann merged commit e6f372b into telekom:master Jun 12, 2024
@selinanatschke-mms selinanatschke-mms deleted the add_class_search_to_threads branch August 6, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants