Feature/pdfutils layout check #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasAdler
requested review from
mreiche,
martingrossmann,
gogro,
mbeuthan and
wolamms
as code owners
martingrossmann
requested changes
Mar 21, 2024
| //reads text from a pdf given as input steam. | ||
| String textFromPdf = PdfUtils.getStringFromPdf(InputStream stream); | ||
| //reads text from only one page of a pdf given as input steam. | ||
| String textFromPdf = PdfUtils.getStringFromPdf(InputStream stream, int pageIndex); |
There was a problem hiding this comment.
It's not the index, but the page number.
| ---- | ||
|
|
||
| == Exporting images | ||
|
|
There was a problem hiding this comment.
Please add a simple example how to store an image from a single page of a PDF and add a comment how the file name is
| String content = PdfUtils.getStringFromPdf(absoluteFilePath, 2); | ||
| Assert.assertFalse(content.contains("This is page 1 of 2"), errorMessage); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add some tests to verify pdfToImage
| * @param dpi The resolution of the rendered image | ||
| * @return A list of rendered image files | ||
| */ | ||
| public static List<File> pdfToImage(String pdfFileLocation, int dpi) { |
There was a problem hiding this comment.
Please rename the method to getImageFromPdf to be consistent with getStringFromPdf
martingrossmann
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
assertImagetoLayoutCheckto provide an option to compare an image file with a reference imageType of change
Please delete options that are not relevant.
Checklist: