Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of failed Screenshot Test in report-ng-test #401

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

clemensgrosse
Copy link
Collaborator

Description

Fix of failing report test concerning screenshots of collected assertions. Test method test_multipleScreenshotsShown, which checks existence of multiple screenshots, now verifies this for test_takeScreenshotViaCollectedAssertion_fails, too.

Fixes issue #390

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] My changes generate no new warnings
  • [ x] New and existing tests pass locally with my changes
  • [x ] Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann merged commit 3cca773 into master Mar 4, 2024
@martingrossmann martingrossmann deleted the fix/screenshot_tests branch March 4, 2024 13:34
@martingrossmann martingrossmann added this to the 2.8 milestone Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants