Link timings and tests #399

selinanatschke-mms · 2024-02-28T13:24:26Z

Description

new filter functionality including a list of chips that are displayed below the usual filter selections and show what filters are currently used
available chip types: clear all, status, class, custom text (free text search), custom filter (when navigating from timings or failure aspects view)
chips can be removed by clicking on the chip or using the clear all chip
added chipNameValueConverter
- uses classNameValueConverter and statusNameValueConverter
- differentiates text on the chip or tooltiptext
added chipClassValueConverter for color encoding
- color encoding: blue for status filter chips, turquoise for class filter chips, purple for free text search chips, defautl grey for all other chip types
implemented functionality to search classes with free text
after filtering classes the chosen classes will not appear in select box anymore
when navigating from timings view: click on a bar => navigate to test view + methods that are represented in bar are filtered in tests view
when navigating from failure aspects view:
- click on failure aspect: methods with that failure aspect are filtered
- click on "failed" badge: methods with that failure aspect are filtered and "failed" status is filtered

Fixes # (issue)

alphabetically sort filter class select options

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

…t list

# Conflicts: # report-ng/app/src/components/timings/test-timings/test-timings.ts

martingrossmann · 2024-02-29T08:29:10Z

I found some issues:

Clicking on a class bar on dashboard should show a filtered test list. But currently the status is not set correctly:
The place between the select boxes and the test table is not big enough. After settting a filter the table is moved down by some pixels. I suppose to keep enough place for the first row of chips to prevent a "shaky" page.
The text searches are compined with OR but needs to be combined with AND.
Please have a look to the report tests which need an update. Maybe we also need some additional tests.

report-ng/app/src/components/timings/test-timings/test-timings.ts

report-ng/app/src/components/classes/classes.ts

report-ng/app/src/services/common-models.ts

report-ng/app/src/value-converters/chip-name-value-converter.ts

report-ng/app/src/value-converters/chip-class-value-converter.ts

report-ng/app/src/components/classes/classes.ts

mreiche · 2024-02-29T10:14:35Z

report-ng/app/src/components/classes/classes.ts

+}
+
+interface IChip {
+    chipElement?: any;


Since we are in the context of a chip, you can remove redundant identifiers: chipElement -> element. Also consider to set the element base type to element: HTMLElement

report-ng/app/src/components/classes/classes.html

report-ng/app/src/components/classes/classes.ts

mreiche · 2024-02-29T11:59:09Z

report-ng/app/src/components/classes/classes.ts

+        this._filter()
+    }
+
+    private _convertQueryParams(params, toArray: boolean){


Could you explain what this method does exactly?
When you want to use multiple values for query parameters, the standard approach would be, to have multiple query parameters with the same name like:
/my-url?q=Search1&q=Search2&class=Class1&class=Class3
This should be supported by any modern framework. Please also see: https://stackoverflow.com/questions/724526/how-to-pass-multiple-parameters-in-a-querystring

I used it to display multiple statuses like status=1~2~3 instead of status=%2C1%2C2 or similar, because the url encoding displayed arrays with filling characters like %2C. The ~ should be like a separator. I chose this with Martin to make the url shorter. It will not be necessary anymore when i implemented your suggestion

for the implementation i have a question and i could not really find an answer online:
If i already have status=4 in my url so i have this.queryParams.status = 4, how do i add a second one so that my url says status=4&status=7 ?
I tried this.queryParams.status = 7 but this just overwrites the 4 in the url, and this.queryParams.status.push or append does not work neither. Using this.queryParams["status"] also has the same results

Do you have any hints or am I misunderstanding something?

mreiche · 2024-03-01T08:13:03Z

Please create new branches in the future and do not reuse old ones.

…xed navigation from dashboard

mreiche · 2024-05-06T09:50:39Z

report-ng/app/src/components/classes/classes.html

@@ -21,7 +21,6 @@

 <template>
    <require from="../../value-converters/chip-name-value-converter"></require>


Is this still necessary?

Yes it is because the values in filters cannot be directly used. Depending on the chip type it needs to be for example "Custom Filter" or "Passed" and for status and Class we need to use other ValueConverter additionally to display the chip labels correctly. All this is handled in the ChipNameValueConverter

mreiche · 2024-05-06T09:51:27Z

report-ng/app/src/components/classes/classes.ts

+            const filter = this.filters.find(filter => filter.type == type);
+
+            if(type != 'config' && type != 'methods'){
+                this.queryParams[type].split("~").forEach(param => {


Please use standard methods for passing multiple URL query parameters. No custom delimiter magic.

I couldn't figure out a better way to modify the queryparams, because the way you proposed earlier is not working (or i could not make it work, here the problem again: #399 (comment))

What would you propose instead?

mreiche · 2024-05-06T09:52:58Z

report-ng/app/src/components/classes/classes.ts

+
+type Filter = {
+    type: FilterType,
+    cssClass: string,


Could have "name" property as well.

See comment for ChipNameValueConverter
=> that is why i removed name property, because this way it would not be used anywhere

report-ng/app/src/value-converters/chip-name-value-converter.ts

martingrossmann · 2024-05-22T13:22:13Z

@mreiche From my side its ok and ready to merge.

sena added 5 commits January 22, 2024 14:44

added navigation from test-timings diagram to tests with filtered tes…

fc1a4a5

…t list

imported mdc-chips

8b775da

Addition to PR telekom#382: adjusted logs view height

8d3ff39

implemented chip filter; implemented free text search for classes

87e9399

Merge branch 'master' into link_timings_and_tests

7df3cf8

# Conflicts: # report-ng/app/src/components/timings/test-timings/test-timings.ts

selinanatschke-mms requested review from mreiche, martingrossmann, gogro, mbeuthan and wolamms as code owners February 28, 2024 13:24

martingrossmann requested changes Feb 29, 2024

View reviewed changes

report-ng/app/src/components/timings/test-timings/test-timings.ts Outdated Show resolved Hide resolved

report-ng/app/src/components/classes/classes.ts Outdated Show resolved Hide resolved

mreiche requested changes Feb 29, 2024

View reviewed changes

mreiche reviewed Feb 29, 2024

View reviewed changes

report-ng/app/src/components/classes/classes.ts Outdated Show resolved Hide resolved

mreiche requested changes Feb 29, 2024

View reviewed changes

added distance between filter and table; changes clear all button; fi…

ad8cc0d

…xed navigation from dashboard

martingrossmann added this to the 2.8 milestone Apr 10, 2024

selinanatschke-mms marked this pull request as draft April 25, 2024 07:47

implemented new chip structure

b61ffad

selinanatschke-mms marked this pull request as ready for review May 6, 2024 07:11

mreiche reviewed May 6, 2024

View reviewed changes

selinanatschke-mms marked this pull request as draft May 7, 2024 06:40

sena added 2 commits May 7, 2024 08:52

fixed search in test cases

103491b

Merge branch 'master' into link_timings_and_tests

f72bbb5

selinanatschke-mms marked this pull request as ready for review May 13, 2024 06:36

martingrossmann reviewed May 17, 2024

View reviewed changes

sena added 2 commits May 21, 2024 07:53

moved chip label texts from chipNameValueConverter to filter

2a57fc6

fixed formatting

a9d0e7c

martingrossmann approved these changes May 22, 2024

View reviewed changes

martingrossmann merged commit 418e301 into telekom:master May 24, 2024

selinanatschke-mms deleted the link_timings_and_tests branch May 27, 2024 08:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Link timings and tests #399

Link timings and tests #399

selinanatschke-mms commented Feb 28, 2024

martingrossmann commented Feb 29, 2024 •

edited

Loading

mreiche Feb 29, 2024

mreiche Feb 29, 2024

selinanatschke-mms Mar 4, 2024

mreiche commented Mar 1, 2024

mreiche May 6, 2024

selinanatschke-mms May 6, 2024

mreiche May 6, 2024

selinanatschke-mms May 6, 2024

mreiche May 6, 2024

selinanatschke-mms May 6, 2024

martingrossmann commented May 22, 2024

		@@ -21,7 +21,6 @@

		<template>
		<require from="../../value-converters/chip-name-value-converter"></require>

Link timings and tests #399

Link timings and tests #399

Conversation

selinanatschke-mms commented Feb 28, 2024

Description

Type of change

Checklist:

martingrossmann commented Feb 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mreiche commented Mar 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martingrossmann commented May 22, 2024

martingrossmann commented Feb 29, 2024 •

edited

Loading