Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timings #389

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Fix timings #389

merged 10 commits into from
Jan 18, 2024

Conversation

selinanatschke-mms
Copy link
Collaborator

@selinanatschke-mms selinanatschke-mms commented Jan 15, 2024

Description

Improved Timings Views

Fixes # (issue)

  • dynamic adjustment of chart height according to:
    https://github.com/telekom/testerra/assets/138661340/bce346ce-ba33-4f2e-b8e3-f9e980de221e
  • tests:
    • added status and configuration badges to test-timings tooltip
      image
    • therefore reset tooltip position to default otherwise the tooltip would be out of the window if the displayed text is too long
    • used existing classes for badges => had to be adjusted via css because spacing for configuration badges was messed up in the tooltip for some reason
  • sessions:
    • fixed that test cases were missing in @before methods
    • adjusted tooltip styling
      • added dividers
    • Note: I wanted to add icons to make it look like the test duration cards from dashboard => not possible since <mdc-icon>-Tags do not work in tooltip (alternative: use <svg> tags but this is not nice; <img> tags were not working because it caused 404 errors
  • Note: Animations in echarts are not working because of its resize functionality, see added aurelia-resize plugin #377 and use aurelia-resize plugin telekom-mms/aurelia-components#97

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@selinanatschke-mms selinanatschke-mms marked this pull request as ready for review January 15, 2024 12:02
@martingrossmann martingrossmann added this to the 2.7 milestone Jan 17, 2024
@martingrossmann martingrossmann merged commit 3aa3c15 into telekom:master Jan 18, 2024
@selinanatschke-mms selinanatschke-mms deleted the fix_timings branch January 22, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants