Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/assert equals #384

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Fix/assert equals #384

merged 6 commits into from
Jan 10, 2024

Conversation

TobiasAdler
Copy link
Collaborator

@TobiasAdler TobiasAdler commented Jan 9, 2024

Description

Using ASSERT.assertEquals() of Testerra with an int, a long and a String as parameters, the assertion would fail even if the values were equal. However using TestNG's Assert.assertEquals(), the assertion would pass. The same would occur with float and double. This behavior was fixed so that the results of TestNG's and Testerra's assertEquals are now the same.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann
Copy link
Contributor

Please add some integration tests that verify your fix.

@TobiasAdler
Copy link
Collaborator Author

TobiasAdler commented Jan 10, 2024

Please add some integration tests that verify your fix.

@martingrossmann Integration tests have been added.

@martingrossmann martingrossmann merged commit 923a934 into master Jan 10, 2024
@martingrossmann martingrossmann deleted the fix/assert-equals branch January 10, 2024 13:56
@martingrossmann martingrossmann added this to the 2.7 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants