Update to Selenium 4.18 - Replace EventFiringWebDriver #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdriver # Conflicts: # driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/WebDriverManagerUtils.java
# Conflicts: # integration-tests/src/test/resources/test.properties
martingrossmann
requested review from
mreiche,
gogro,
mbeuthan and
wolamms
as code owners
martingrossmann
changed the title
martingrossmann
changed the title
mreiche
requested changes
Feb 20, 2024
.../main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/VisualEventDriverListener.java
Outdated
Show resolved
Hide resolved
.../main/java/eu/tsystems/mms/tic/testframework/webdrivermanager/VisualEventDriverListener.java
Outdated
Show resolved
Hide resolved
| if (!desktopWebDriverRequest.getBaseUrl().isPresent()) { | ||
| WebDriverManager.getConfig().getBaseUrl().ifPresent(desktopWebDriverRequest::setBaseUrl); | ||
| } | ||
| VisualEventDriverListener visualListener = new VisualEventDriverListener(); |
There was a problem hiding this comment.
Why not instantiating VisualEventDriverListener only when Testerra.Properties.DEMO_MODE.asBool()?
There was a problem hiding this comment.
The new EventFiringDecorator gets a list of custom listeners and returns the decorated webdriver, see some lines below. I cannot update a decorated driver with another listener.
And switch or if statements for different ways to create my decorated webdriver make the code more complex.
mreiche
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The listener
EventFiringWebDriveris deprecated and was also removed in current Selenium trunk (SeleniumHQ/selenium#13200).Selenium now provides
EventFiringDecoratorandWebDriverListener. This change includes an update to Selenium 4.18.1.There is still an open PR which adds some more methods to
WebDriverListenerwe want to use:4.174.18 releasedOther ToDos:
unwrapmethods, maybe not needed any more --> still needed to get orginal driver from decorated one.eventFiringWebdrivervariables towebDriverType of change
Please delete options that are not relevant.
Checklist: