Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/356 ttscreenshotteractive causes npe at collected assertions #357

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix/356 ttscreenshotteractive causes npe at collected assertions #357

merged 3 commits into from
Sep 26, 2023

Conversation

martingrossmann
Copy link
Contributor

Description

Fixes an NPE when using property tt.screenshotter.active=false.

Fixes #356

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann linked an issue Sep 25, 2023 that may be closed by this pull request
tt.screenshotter.active causes NPE at collected assertions #356
Closed
mreiche
mreiche reviewed Sep 25, 2023
View reviewed changes
...c/main/java/eu/tsystems/mms/tic/testframework/execution/testng/DefaultOptionalAssertion.java Outdated
methodContext.addScreenshot(screenshot);
report.addScreenshot(screenshot, Report.FileMode.MOVE);
});
if (screenshots != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this double gemoppeld?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed...

@martingrossmann martingrossmann merged commit e57b105 into master Sep 26, 2023
@martingrossmann martingrossmann deleted the fix/356-ttscreenshotteractive-causes-npe-at-collected-assertions branch September 26, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreiche mreiche mreiche approved these changes

@gogro gogro Awaiting requested review from gogro

@mbeuthan mbeuthan Awaiting requested review from mbeuthan mbeuthan is a code owner

@wolamms wolamms Awaiting requested review from wolamms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tt.screenshotter.active causes NPE at collected assertions
2 participants
@martingrossmann @mreiche