Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mail connector attachments #355

Merged
merged 7 commits into from
Sep 21, 2023

Conversation

TobiasAdler
Copy link
Collaborator

@TobiasAdler TobiasAdler commented Sep 21, 2023

Description

  • Added a data driven testcase for different binary attachments in MailConnectorTest and adjusted the testcase for plain text attachment
  • Created a new object EmailAttachment which stores the name, input stream and the encoding of an attached file
  • Adjusted readMessageContents(), getCharSetForEncoding() and other methods of Email object to work proberly with binary files and the new EmailAttachment object

Fixes #347

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann merged commit ed4e717 into master Sep 21, 2023
@martingrossmann martingrossmann deleted the fix/mail-connector_attachments branch September 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testerra Mail Connector misshandles pdf attachements
2 participants