Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/layout model #354

Merged
merged 16 commits into from
Oct 11, 2023
Merged

Fix/layout model #354

merged 16 commits into from
Oct 11, 2023

Conversation

martingrossmann
Copy link
Contributor

@martingrossmann martingrossmann commented Sep 5, 2023

Description

The additional information (images for actual, diff, expected) of the result of a pixel based layout check were only stored as a Map and were exported to the report in a JSON format.
This change introduces a LayoutCheckContext model which can be better handed by ReportNG and other platforms working with report data model.

Every LayoutCheckContext is linked to it's own ErrorContext. This allows as follows:

  • more then one layout check assertion in a testcase.
  • Mix of UiElement assertions and layout check assertion as collected assertions in one test case

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann martingrossmann marked this pull request as ready for review September 14, 2023 16:26
@martingrossmann martingrossmann merged commit ca2d468 into master Oct 11, 2023
@martingrossmann martingrossmann deleted the fix/layout-model branch October 11, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants