Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reportng renewed threads view #350

Merged
merged 65 commits into from
Sep 25, 2023

Conversation

TobiasAdler
Copy link
Collaborator

@TobiasAdler TobiasAdler commented Aug 21, 2023

Description

The old threads view was replaced with a new one using Apache ECharts.
Details of a testcase (method name, run index, start- and end-time and duration) are provided with a tooltip.
In Addition to the method filter, a status filter was added. With the selection of a status all testcases of that status are highlighted and zoomed in on. These two filters can not be active at the same time, instead they cancel each other out.
The Method filter itself highlights the selected testcase and performs a zoom event on that specific method.

New Threads View with active tooltip:
threads_new_2

Status Filter active:
threads_new_4

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

TobiasAdler and others added 30 commits April 24, 2023 12:58
mreiche
mreiche previously approved these changes Aug 25, 2023
@martingrossmann
Copy link
Contributor

martingrossmann commented Aug 30, 2023

@TobiasAdler In case of many configuration methods (e.g. many BeforeMethods) the method list contains many entries with the same name:
image

Please add the run index in brackets like setUp (20) to increase clarity.

@martingrossmann
Copy link
Contributor

@TobiasAdler Please also update the ReportNG tests. We have some failed tests because of changed Threads view.

mreiche
mreiche previously approved these changes Sep 12, 2023
mbeuthan
mbeuthan previously approved these changes Sep 15, 2023
@TobiasAdler TobiasAdler dismissed stale reviews from mbeuthan and mreiche via f3e239d September 21, 2023 08:38
@martingrossmann martingrossmann merged commit adfd459 into master Sep 25, 2023
@martingrossmann martingrossmann deleted the feature/reportng-renewed_threads_view branch September 25, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants