Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reportng error message #330

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Conversation

TobiasAdler
Copy link
Collaborator

@TobiasAdler TobiasAdler commented Jun 26, 2023

Description

In specific cases, the cut of the identifier message in statistic-models caused the loss of valuable information about the occurring error, which then could not be seen in the report. This was fixed by replacing occurring line-breaks with a space-character.

Error message before change:
error_message_before

Error message afte change:
error_message_after

In Addition in the failure-aspects-view of the testerra report, the highlighting of occurring strings in the error message did not work properly, which was fixed as well.

Failure Aspects before change:
failure_aspects_before

Failure Aspects after change:
failure_aspects_after

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@mreiche mreiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add screenshots of the Change?

// this.message = this.relevantCause.message;
// }

// Replace all occurring line-breaks with a space-character
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don’t remove this orphaned code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned code was removed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@mreiche mreiche self-requested a review June 28, 2023 11:40
@martingrossmann martingrossmann merged commit 5b680f4 into master Jun 28, 2023
@martingrossmann martingrossmann deleted the fix/reportng-error-message branch June 28, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants