Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and improved the image layout check #297

Merged
merged 11 commits into from
Jan 30, 2023
Merged

Conversation

martingrossmann
Copy link
Contributor

Description

  • The report shows the real difference image, not a self generated
  • Added test for check the handling of RGB deviation
  • Updated documentation
  • Fixed the multiple assertion message in report if dimensions of reference and actual image are not equal

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mbeuthan
mbeuthan previously approved these changes Jan 10, 2023
gogro
gogro previously approved these changes Jan 11, 2023
# Conflicts:
#	driver-ui/src/main/java/eu/tsystems/mms/tic/testframework/layout/LayoutCheck.java
@martingrossmann martingrossmann dismissed stale reviews from gogro and mbeuthan via a44266b January 11, 2023 16:10
@martingrossmann martingrossmann merged commit 8cdea4e into master Jan 30, 2023
@martingrossmann martingrossmann deleted the fix/layout-check branch January 30, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants