Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/report session video size #270

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

martingrossmann
Copy link
Contributor

@martingrossmann martingrossmann commented Sep 13, 2022

Description

In case of session videos in portrait mode (mobile devices) the videos are to height for the session view. This change fixes the video tag height according screen size.
I also fixed the width of the capability view behind the video. For some appium servers you need an authentication key which expand the view. The y scrolling was not working without width: .. px.

New view:
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

mbeuthan
mbeuthan previously approved these changes Sep 14, 2022
Zsar
Zsar previously approved these changes Sep 16, 2022
*/

@media screen and (min-width: 1024px) {
video { height: 300px; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these really be pixel values? I'd expect some - any - relative size.

@martingrossmann martingrossmann dismissed stale reviews from Zsar and mbeuthan via 9bcfc85 September 19, 2022 06:08
@martingrossmann martingrossmann merged commit cf454c2 into master Sep 20, 2022
@martingrossmann martingrossmann deleted the fix/report-session-video-size branch September 20, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants