-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/format code error details #255
Conversation
the generated output created immense log lines that no one ever read but influenced the way we could display logs in the report heavily
This reverts commit 0868a7e.
this also removes links that were shown on PageFactoryExceptions
@@ -19,7 +19,7 @@ | |||
* under the License. | |||
*/ | |||
|
|||
@import "styles/statuses"; | |||
@import "../../styles/statuses"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that relative path needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least IDEA complains about not finding the old one. Not quite sure whether SASS adds magic, but as far as I know, pathes have to be absolute or relative but not "module-like" like for EcmaScript modules.
So, looks sensible to me. Even if it still worked without, I'd deem it sufficiently minor to consider appeasing the IDE a sufficient reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted this change since aurelia or something else seems to resolve this properly.
aurelia seems to take core of that
Description
fixes: code view in error details is displayed properly formatted
fixes: HTML in error messages no longer gets rendered -> this was an issue with Selenium exceptions that included part of the html code where the exception occured.
As a result of this fix URLs that were added to error messages only get displayed as plain text and not as links.
Type of change
Please delete options that are not relevant.
Checklist: