Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/format code error details #255

Merged
merged 10 commits into from
Jul 15, 2022
Merged

Conversation

sbke-mms
Copy link
Collaborator

Description

fixes: code view in error details is displayed properly formatted
fixes: HTML in error messages no longer gets rendered -> this was an issue with Selenium exceptions that included part of the html code where the exception occured.
As a result of this fix URLs that were added to error messages only get displayed as plain text and not as links.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -19,7 +19,7 @@
* under the License.
*/

@import "styles/statuses";
@import "../../styles/statuses";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that relative path needed?

Copy link

@Zsar Zsar Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least IDEA complains about not finding the old one. Not quite sure whether SASS adds magic, but as far as I know, pathes have to be absolute or relative but not "module-like" like for EcmaScript modules.

So, looks sensible to me. Even if it still worked without, I'd deem it sufficiently minor to consider appeasing the IDE a sufficient reason.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted this change since aurelia or something else seems to resolve this properly.

aurelia seems to take core of that
@sbke-mms sbke-mms merged commit 4d71ca6 into master Jul 15, 2022
@sbke-mms sbke-mms deleted the fix/format_code_error_details branch July 15, 2022 08:24
@martingrossmann martingrossmann mentioned this pull request Oct 6, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants