Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to JDK11 #250

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Updated to JDK11 #250

merged 2 commits into from
Jul 7, 2022

Conversation

martingrossmann
Copy link
Contributor

Description

Raised the language level to JDK11.

Fixes #194

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@martingrossmann
Copy link
Contributor Author

This is strange: The most important change is the update of the language level in build.gradle, but Github says it is already done. But it is not!

@Zsar
Copy link

Zsar commented Jul 6, 2022

FWIW: This shows the expected diff:

git checkout master
git pull
git fetch origin feature/testerra2-jdk11
git diff HEAD..FETCH_HEAD -- build.gradle

so, yes, must be an issue with GitHub.

... Here it is for ease of reference:

diff --git a/build.gradle b/build.gradle
index 1f0bdbd9b..572abf844 100644
--- a/build.gradle
+++ b/build.gradle
@@ -35,8 +35,8 @@ allprojects {

     compileJava.options.encoding = 'UTF-8'
     compileTestJava.options.encoding = "UTF-8"
-    sourceCompatibility = JavaVersion.VERSION_1_8
-    targetCompatibility = JavaVersion.VERSION_1_8
+    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_11

 }

@@ -56,7 +56,6 @@ subprojects {
     repositories {
         mavenLocal()
         mavenCentral()
-        jcenter()
     }

     jacoco {

@Zsar
Copy link

Zsar commented Jul 6, 2022

Created a Github bug ticket. Maybe we could wait a day or two with merging, so they have a better chance to dig through their backend. (If they do in time, that is. Definitely not advocating to wait for longer than end of the week.)

@martingrossmann martingrossmann merged commit 432150a into master Jul 7, 2022
@martingrossmann martingrossmann deleted the feature/testerra2-jdk11 branch July 7, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise language level to Java 11
3 participants