Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed JUnit XML result generator #182

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

martingrossmann
Copy link
Contributor

Description

The old JUnit XML result generator ignored skipped tests and did not handle retried tests. Furthermore the old generator based on and old version of Maven Surefire Plugin (https://github.com/apache/maven-surefire/tree/b9b2381a3dba6574bb69bd91d45fe0edea29c779/surefire-api/src/main/java/org/apache/maven/surefire/api/report).

TestNG has an own JUnitXmlReporter listener (https://github.com/cbeust/testng/blob/master/testng-core/src/main/java/org/testng/reporters/JUnitXMLReporter.java). The TestNG implemenation was migrated to Testerra event system.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mreiche mreiche added this to the 1.11 milestone Dec 6, 2021
@martingrossmann martingrossmann merged commit 49e43c0 into master Dec 6, 2021
@martingrossmann martingrossmann deleted the fix/fix-xml-results branch December 6, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants