Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/retry model #146

Merged
merged 27 commits into from
Nov 5, 2021
Merged

Refactoring/retry model #146

merged 27 commits into from
Nov 5, 2021

Conversation

mreiche
Copy link
Collaborator

@mreiche mreiche commented Nov 1, 2021

Description

Completly refactored test status model.

Retried tests are no longer part of the statistic:
image

More detailed information on the status badge:
image

Links between retried methods:
image
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mreiche mreiche added this to the 1.9 milestone Nov 1, 2021
mbeuthan
mbeuthan previously approved these changes Nov 3, 2021
@mreiche mreiche requested a review from mbeuthan November 3, 2021 11:58
@martingrossmann
Copy link
Contributor

martingrossmann commented Nov 3, 2021

After some changes this is the latest version of the dashboard after executing the class TestNgDependsOnRetryTest:
image

image

  • The retried test is part of the executed tests (5 tests) but it has no impact to the whole test result. This is passed
  • The failure aspect comes from the retried test.
  • The dashboard filter for Failed ignores the retried test. This test is only available in the Tests area.

@gogro @mbeuthan Please review. :-)

mbeuthan
mbeuthan previously approved these changes Nov 4, 2021
@mreiche mreiche merged commit 6a96aec into master Nov 5, 2021
@mreiche mreiche deleted the refactoring/retry-model branch November 5, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RETRY statuses
3 participants