Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crashed test when baseUrl could not be opened. #104

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

mreiche
Copy link
Collaborator

@mreiche mreiche commented Aug 18, 2021

Description

Dont throw Exception when the base URL could not be opened for some reason.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mreiche mreiche merged commit 455e749 into master Aug 25, 2021
@mreiche mreiche deleted the bugfix/connection-refused-workarround branch August 25, 2021 12:19
@martingrossmann martingrossmann added this to the 1.7 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants