Skip to content

Commit

Permalink
Minor improvements and cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
TobiasAdler committed Feb 21, 2024
1 parent 29283a2 commit fd09c78
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 15 deletions.
8 changes: 7 additions & 1 deletion docs/src/docs/reports/timings-view.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ This way you can adjust the resolution of the chart.
You can also search for a specific method by entering the name of the test case in the searchbar.
The corresponding bar is then highlighted.

By default, only the test methods themselves are included. However, it is possible to incorporate the configuration methods by toggling the switch located in the top right corner of the view.
By default, only the test methods themselves are included.
However, it is possible to incorporate the configuration methods by toggling the switch located in the top right corner of the view.

image::report-ng-timings-view_tests.png[align="center", alt="Tests"]

Expand All @@ -20,6 +21,11 @@ On the x-axis, the starting time of session is indicated, while the loading dura

When hovering over any of the dots, a tooltip appears providing details regarding the browser and its version, the session name and ID, along with the test cases executed within that session.

If a base URL is configured, the load duration and timestamp of the base URL are also displayed.
In this scenario, the two dots are linked, as the base URL is consistently loaded at session startup.
Note that setting up a base URL is optional.
If both dots exist, the hover effect will clarify which base URL dot corresponds to each session dot.

Navigation:

* Use the mouse wheel to zoom in or out on the y-axis.
Expand Down
Binary file modified docs/src/images/report-ng-timings-view_sessions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/src/images/report-ng-timings-view_tests.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -573,19 +573,25 @@ public WebDriver getDriver() {
return getWebDriver();
}

/**
* @deprecated Use {@link GuiElement#hasSensitiveData()}} instead
*/
@Deprecated
public boolean hasSensibleData() {
return guiElementData.hasSensibleData();
return guiElementData.hasSensitiveData();
}

public boolean hasSensitiveData() {
return guiElementData.hasSensitiveData();
}

/**
* @deprecated Use {@link GuiElement#sensitiveData()}} instead
*/
@Deprecated
@Override
public GuiElement sensibleData() {
guiElementData.setHasSensibleData(true);
guiElementData.setHasSensitiveData(true);
return this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ public Object getDefault() {

UiElement shadowRoot();

/**
* @deprecated Use {@link UiElement#sensitiveData()}} instead
*/
@Deprecated
UiElement sensibleData();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public class GuiElementData implements
private GuiElement guiElement;
private String name;
private boolean shadowRoot = false;
private boolean sensibleData = false;
private boolean sensitiveData = false;
private boolean isFrame = false;

Expand Down Expand Up @@ -114,21 +113,10 @@ public GuiElementData setHasShadowRoot(boolean shadowRoot) {
return this;
}

@Deprecated
public boolean hasSensibleData() {
return sensibleData;
}

public boolean hasSensitiveData() {
return sensitiveData;
}

@Deprecated
public GuiElementData setHasSensibleData(boolean sensibleData) {
this.sensibleData = sensibleData;
return this;
}

public GuiElementData setHasSensitiveData(boolean sensitiveData) {
this.sensitiveData = sensitiveData;
return this;
Expand Down

0 comments on commit fd09c78

Please sign in to comment.