Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vars parameter to notification templates, task icinga_serviceset swap #271

Merged

Conversation

gianmarco-mameli
Copy link
Contributor

Hi,
The icinga_notification_template module doesn't have the possiblity to add vars to template, so I've implemented it and tested.

Also, while testing a complete recovery for my personal cluster, I've found that on the main task of the role, the icinga_serviceset is called after icinga_service, and that is a problem because every service connected to a serviceset, needs the service_set parameter, so I simply swapped the order, first service sets task and next the services task

Thanks

@gianmarco-mameli gianmarco-mameli requested a review from a team as a code owner November 28, 2024 22:26
@rndmh3ro rndmh3ro enabled auto-merge (squash) November 29, 2024 10:30
@rndmh3ro rndmh3ro merged commit 848d368 into telekom-mms:main Nov 29, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants