Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique labels to api and watcher services #425

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

enarha
Copy link
Contributor

@enarha enarha commented Apr 3, 2023

Changes

Added unique labels to the api and watcher services. One use case for having them is to match each service in ServiceMonitor for metrics collection. Both api and watcher already expose Prometheues metrics.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • [ x] Tested your changes locally (if this is a code change)
  • [x ] Follows the commit message standard
  • [x ] Meets the Tekton contributor standards (including functionality, content, code)
  • [x ] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Added unique labels to api and watcher services.

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 3, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2023
@alan-ghelardi
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2023
Added unique labels to the api and watcher services. One use case for
having them is to match each service in ServiceMonitor for metrics
collection. Both api and watcher already expose Prometheues metrics.
@enarha
Copy link
Contributor Author

enarha commented Apr 12, 2023

@adambkaplan It looks we got enough approvals here. Can we merged this PR please.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Absolutely makes sense to do this, since the service are using the same label for the pod selector. It is also worth noting that the "metadata" component in the config folder adds other recommended labels that allow all of Results data to be grouped together.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, alan-ghelardi, avinal, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,alan-ghelardi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit b323c07 into tektoncd:main Apr 12, 2023
@enarha enarha deleted the add-service-labels branch April 19, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants