-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique labels to api and watcher services #425
Conversation
/approve |
Added unique labels to the api and watcher services. One use case for having them is to match each service in ServiceMonitor for metrics collection. Both api and watcher already expose Prometheues metrics.
3f4171b
to
43fda31
Compare
@adambkaplan It looks we got enough approvals here. Can we merged this PR please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Absolutely makes sense to do this, since the service are using the same label for the pod selector. It is also worth noting that the "metadata" component in the config folder adds other recommended labels that allow all of Results data to be grouped together.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, alan-ghelardi, avinal, sayan-biswas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Added unique labels to the api and watcher services. One use case for having them is to match each service in ServiceMonitor for metrics collection. Both api and watcher already expose Prometheues metrics.
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes