Fix: Error message for GetResult handler #346
Conversation
tekton-robot
added
the
size/XS
|
🙈 |
|
/approve |
tekton-robot
added
the
approved
| if err := errors.Wrap(gdb.Where(&db.Result{Parent: parent, Name: name}).First(r).Error); err != nil { | ||
| return nil, status.Errorf(status.Code(err), "failed to query on database: %v", err) | ||
| q := gdb. | ||
| Where(&db.Result{Parent: parent, Name: name}). | ||
| First(r) | ||
| if err := errors.Wrap(q.Error); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Do we have a means of unit testing this error message?
There was a problem hiding this comment.
@sayan-biswas bump on this question.
There was a problem hiding this comment.
This errors are actually returned from the gorm package. In this repo we only have a wrapper. Untill we have a predefined set of error messages for all the RPCs, we can't create unit test to check the message string.
tekton-robot
added
the
do-not-merge/release-note-label-needed
Fix Issue tektoncd#337, error message for GetResult handler.
sayan-biswas
force-pushed
the
fix-issue-337
branch
from
ebe670f
to
76f3ed1
Compare
|
/release-note-none |
tekton-robot
added
release-note-none
|
@adambkaplan ok to merge? |
tekton-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, alan-ghelardi, avinal, khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #337
Fix error message for GetResult handler.
Current: Shows wrapped RPC error message
{"code":5, "message":"failed to query on database: rpc error: code = NotFound desc = record not found", "details":[]}Expected: Standard message
{"code":5, "message":"record not found", "details":[]}Release Note