Use TriggerGroups for CI Jobs 🥳 #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
kind/feature
tekton-robot
added
the
size/L
afrittoli
force-pushed
the
trigger_groups
branch
from
6089518 to
9f6336e
Compare
tekton-robot
added
size/XL
|
/cc @jmcshane @tektoncd/triggers-maintainers @vdemeester |
|
@afrittoli: GitHub didn't allow me to request PR reviews from the following users: jmcshane. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
afrittoli
force-pushed
the
trigger_groups
branch
from
9f6336e to
48b0496
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
TriggerGroups are a new alpha feature in Triggers that allow define a set of interceptors that will be processed before Trigger resources for a filtered group of Triggers. All triggers in CI jobs deal with GitHub event so they share a large surface of the interceptors. Using TriggerGroups makes it easier to maintain the triggers for all projects. The change is not only cosmetic though: interceptors like github, cel, add-pr-body will be processed only once. The hash in the GitHub event is going to be validated once. The PR definition will be pulled from the GitHub API once (per trigger group) instead of once per trigger. This paves the way for further changes: - add the add-team-member custom interceptor and logic so we only run tests for authorised users - add a trigger group to add comments that enahnce the user experience Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
afrittoli
force-pushed
the
trigger_groups
branch
from
48b0496 to
a35742a
Compare
This was referenced Dec 10, 2021
|
/lgtm |
afrittoli
added a commit
to afrittoli/plumbing
that referenced
this pull request
Dec 14, 2021
All trigger resources are still v1alpha1. Migrating the CI event listener for now since it's required by for trigger groups: tektoncd#956 Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
1 task
tekton-robot
pushed a commit
that referenced
this pull request
Dec 14, 2021
All trigger resources are still v1alpha1. Migrating the CI event listener for now since it's required by for trigger groups: #956 Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TriggerGroups are a new alpha feature in Triggers that allow define
a set of interceptors that will be processed before Trigger resources
for a filtered group of Triggers.
All triggers in CI jobs deal with GitHub event so they share a large
surface of the interceptors. Using TriggerGroups makes it easier to
maintain the triggers for all projects.
The change is not only cosmetic though: interceptors like github,
cel, add-pr-body will be processed only once. The hash in the GitHub
event is going to be validated once. The PR definition will be pulled
from the GitHub API once (per trigger group) instead of once per
trigger.
This paves the way for further changes:
run tests for authorised users
Signed-off-by: Andrea Frittoli andrea.frittoli@uk.ibm.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind feature